-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented strides for AbstractArray subtypes #30429
Conversation
Thanks for the contribution! We should probably make the documentation of This means that, for example See https://docs.julialang.org/en/v1/manual/interfaces/#man-interface-strided-arrays-1 for a bit more detail — but probably still not quite enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define strides(::AdjOrTrans)
in terms of the strides of its parent, and remove the strides definition for Diagonal
@mbauman If i am correctly understanding strides
|
It's even simpler than that — you just want to reverse the strides of the parent. Oh my, now that I write that out, it's sounding very familiar to me… Yup, shucks. #29135. I have a really bad habit of submitting PRs and then forgetting all about them. |
@mbauman Haha!! You've already implemented it way before than me?Should I continue working on this?Also should I split the function for StridedMatrix and StridedVector as you did? |
@mbauman Should we merge your old PR, or should @raghav9-97 prepare this one to be merged? |
Fixes #29705