Add Float16 comparisons

[sam0410]

All the discussions corresponding to this PR is in #29870
Fixes issue #29743

[stevengj]

Seems like you could use a loop for this kind of repetitive definition. For example:

for op in (:==, :<, :>)
    @eval begin
        $op(x::Union{Float16,Float32}, y::Union{Int128,UInt128}) = $op(Float64(x), Float64(y))
        $op(x::Union{Int128,UInt128}, y::Union{Float16,Float32}) = $op(Float64(x), Float64(y))
    end
end

[sam0410]

Hi @stevengj, I removed the @eval because of the following comment by @andyferris :
#29870 (comment)

Or would it be better if I add the for loop for a more readable code?

[stevengj]

If @eval can replace many lines of repetitive code with a much shorter loop, it is a good idea. The comment by @andyferris was referring to cases where there is little or no code savings.

[sam0410]

The build is failing because of some 32bit issue, not because of the code in this PR.

[stevengj]

The AppVeyor failure is an inference failure on 32-bit Windows. It's not completely clear to me that it is unrelated — are we seeing the same failure on other PRs?

[fredrikekre]

The AppVeyor failure is an inference failure on 32-bit Windows.

See #29923, happens on most PRs

[sam0410]

Hi, Is this PR ready to be merged ? Or is there something else I could change?

[StefanKarpinski]

Be sure to squash when merging.

[kshyatt]

CI ran out of logspace. This still ok to squash and merge?

[StefanKarpinski]

Rerunning CI to be sure.

[StefanKarpinski]

@stevengj already approved, so if CI passes, someone please merge.

[stevengj]

@fredrikekre, I don't think a bugfix like this requires a NEWS item…?

[fredrikekre]

Ok, thought it was MethodErrors before.