Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple missing tests for BitArray #29814

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Couple missing tests for BitArray #29814

merged 1 commit into from
Nov 1, 2018

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Oct 26, 2018

No description provided.

@kshyatt kshyatt added the test This change adds or pertains to unit tests label Oct 26, 2018
@kshyatt kshyatt requested a review from ararslan October 26, 2018 17:12
for ii in 1:length(sz)
@test isassigned(a, ii)
@test isassigned(b, ii)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to also test !isassigned for some out of bounds ii while you're at it.

@kshyatt
Copy link
Contributor Author

kshyatt commented Nov 1, 2018

Updated the test to actually get at all the assigned indices...

@mbauman
Copy link
Member

mbauman commented Nov 1, 2018

Appveyor failure is unrelated (but interesting — some string is empty that shouldn't be?):

Test Failed at C:\projects\julia\julia-\share\julia\stdlib\v1.1\Profile\test\runtests.jl:34
  Expression: !(isempty(str))
Error in testset Profile:
Test Failed at C:\projects\julia\julia-\share\julia\stdlib\v1.1\Profile\test\runtests.jl:41
  Expression: !(isempty(String(take!(iobuf))))
Error in testset Profile:
Error During Test at C:\projects\julia\julia-\share\julia\test\testdefs.jl:19
  Got exception outside of a @test
  LoadError: ArgumentError: reducing over an empty collection is not allowed
  Stacktrace:
   [1] _empty_reduce_error() at .\reduce.jl:216
   [2] reduce_empty(::Function, ::Type) at .\reduce.jl:226
   [3] mapreduce_empty(::typeof(identity), ::Function, ::Type) at .\reduce.jl:251
   [4] _mapreduce(::typeof(identity), ::typeof(max), ::IndexLinear, ::Array{Int32,1}) at .\reduce.jl:305
   [5] _mapreduce_dim at .\reducedim.jl:305 [inlined]
   [6] #mapreduce#535 at .\reducedim.jl:301 [inlined]
   [7] mapreduce at .\reducedim.jl:301 [inlined]
   [8] _maximum at .\reducedim.jl:650 [inlined]
   [9] _maximum at .\reducedim.jl:649 [inlined]
   [10] #maximum#541 at .\reducedim.jl:645 [inlined]
   [11] maximum at .\reducedim.jl:645 [inlined]
   [12] print_flat(::Base.GenericIOBuffer{Array{UInt8,1}}, ::Array{Base.StackTraces.StackFrame,1}, ::Array{Int32,1}, ::Int32, ::Profile.ProfileFormat) at C:\projects\julia\usr\share\julia\stdlib\v1.1\Profile\src\Profile.jl:398

@mbauman mbauman merged commit 6a3a75a into master Nov 1, 2018
@mbauman mbauman deleted the ksh/bitarray branch November 1, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants