Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English fixes #29336

Merged
merged 1 commit into from
Oct 4, 2018
Merged

English fixes #29336

merged 1 commit into from
Oct 4, 2018

Commits on Sep 24, 2018

  1. English fixes

    I did not change "i.e." to "i.e.," even though I think the latter is better since the former seems to be your standard.
    
    I find the package name 'Priv' v. confusing esp. in contexts like "The public `Priv`" etc. I think Util would be a more plausible and less
    confusing example name. (I also think 'Pub' ought to be replaced by a more plausible name, e.g., 'Process' or 'Compute'.)
    
    I find it confusing that the text mentions the "/home/me/animals" directory, but then shows a dictionary using "/home/me/AnimalPackages".
    
    PS I tried doing this from a local git clone but when I did the git push it gave me a 403.
    I did git clone ...julia.git, the cd'd into julia, then did git checkout -b english_fixes, then made my changes and did git commit -a, put in the comments above, then did git push --set-upstream origin english_fixes, entered my git username and password -- and then got the 403. I can carry on using the web interface though.
    mark-summerfield authored Sep 24, 2018
    Configuration menu
    Copy the full SHA
    5f17675 View commit details
    Browse the repository at this point in the history