-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP/RFC] Test and document embedding with dynamically loaded libjulia. #28886
Changes from all commits
3463fe0
c83a0d4
b09b7fa
7d6bcd1
b048aa3
ce8620a
fee921e
bec1203
d7b5d17
1c175f1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
/embedding | ||
/embedding-debug | ||
/embeddingdl | ||
/embeddingdl-debug |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,11 @@ | |
|
||
JULIA_DEFINE_FAST_TLS() // only define this once, in an executable | ||
|
||
// Extracted from src/support/platform.h | ||
#if defined(_WIN32) || defined(_WIN64) | ||
#define _OS_WINDOWS_ | ||
#endif | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did this need to be added to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very good question. I don't see that myself now. Backing it out and see if it still passes CI is probably probably the best option. |
||
|
||
#ifdef _OS_WINDOWS_ | ||
__declspec(dllexport) __cdecl | ||
#endif | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
const julia_sqrt = @cfunction(sqrt, Cdouble, (Cdouble,)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The part above looks (almost?) exactly like
@testset "embedding example"
and could be factored out into a function.