Pkg: make sure LibGit2 repo closes if we fail in install_git #28030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
packages
|
Didn't work, let's try comment out the test that fails and see if that is actually the problem... |
|
Doesn't error on AV now. I'll rerun it and see if it still passes. If so, I'll merge this to disable the offending test to not cause red CI while working on trying to resolve it. |
|
Ok, let's disable this test for now then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran AV on Pkg.jl repo 5 times in a row without failing with this, so let's see how it works here.
Should fix #27982 (again)