RFC: Deprecate findfirst on I/O buffers #26600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two methods are exceptions in the API as we generally do not support find* for non-indexable collections. occursin and readuntil are replacements for most typical cases (but not all).
nalimilan
added
io
vtjnash
approved these changes
Mar 23, 2018
| @@ -1565,6 +1562,14 @@ end | |||
| @deprecate ucfirst uppercasefirst | |||
| @deprecate lcfirst lowercasefirst | |||
|
|
|||
| function search(buf::IOBuffer, delim::UInt8) | |||
There was a problem hiding this comment.
This should be for GenericIOBuffer.
There was a problem hiding this comment.
...with the more generic implementation of course. Otherwise it seems we're missing a deprecation for search(::GenericIOBuffer, ...
There was a problem hiding this comment.
GenericIOBuffer isn't exported, so is it really worth having a deprecation?
JeffBezanson
approved these changes
Mar 23, 2018
|
Another problem with these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two methods are exceptions in the API as we generally do not support
find*for non-indexable collections.occursinandreaduntilare replacements for most typical cases (but not all).Possible counter-arguments to this change:
IOBufferis special since even if it's not indexable, it supportsposition: it could make sense to look for the position ofdelimdelim