make tempname on windows match unix behavior
#25530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Jan 12, 2018
base/file.jl
Outdated
| @@ -344,6 +358,9 @@ tempdir() | |||
| tempname() | |||
|
|
|||
| Generate a unique temporary file path. | |||
| Warning: this can lead to race conditions if another process obtains the same | |||
There was a problem hiding this comment.
You could make this a Documenter-style warning:
!!! warning
This can lead to race conditions if another process obtains the same
file name and creates the file before you are able to.
Using [`mktemp()`](@ref) is recommended instead.
ararslan
added
deprecation
|
+1, I like this approach. I was looking into this the other day and I found that in a lot of cases |
JeffBezanson
force-pushed
the
jb/tempname
branch
from
da609e2
to
e551cec
Compare
ararslan
reviewed
Jan 12, 2018
base/file.jl
Outdated
| @@ -344,6 +358,12 @@ tempdir() | |||
| tempname() | |||
|
|
|||
| Generate a unique temporary file path. | |||
There was a problem hiding this comment.
It would probably be good to specify here that the file is not created.
JeffBezanson
force-pushed
the
jb/tempname
branch
3 times, most recently
from
0209dc7
to
50d8320
Compare
JeffBezanson
force-pushed
the
jb/tempname
branch
from
50d8320
to
b323c31
Compare
JeffBezanson
changed the title
tempname on windows match unix behaviortempname on windows match unix behavior
|
Nice to see another 4-digit issue resolved. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a possible fix to #9053. From re-reading the thread I decided the following:
tempnameis not recommended, it has uses and it would be annoying for us to remove it.So this PR does the following:
tempnameon windows not to create the file, like unix. According to the docs it is possible to callGetTempFileNameWsuch that it doesn't create the file.tempname(::UInt32)because it's just weird.tempnamein Pkg tomktemp