Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash(::AbstractArray) failure in when some types support - and others do not #25250

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

nalimilan
Copy link
Member

The existing code (recently added by #16401) only checked that subtraction was supported for the first two elements, but not for subsequent elements, which is necessary for heterogeneous arrays.

Also fix a StackOverflow error due to the widen fallback calling itself recursively by throwing a MethodError manually.

…hers do not

The existing code only checked that subtraction was supported for the first two elements,
but not for subsequent elements, which is necessary for heterogeneous arrays.

Also fix a StackOverflow error due to the widen() fallback calling itself recursively
by throwing a MethodError manually.
@nalimilan
Copy link
Member Author

@StefanKarpinski Good to merge?

@StefanKarpinski
Copy link
Member

Ah yes, good to go, although probably needs a rebase and a fresh CI run.

@nalimilan nalimilan closed this Jan 2, 2018
@nalimilan nalimilan reopened this Jan 2, 2018
@nalimilan nalimilan merged commit 3d1886f into master Jan 3, 2018
@nalimilan nalimilan deleted the nl/hashfix branch January 3, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants