Remove keyword argument performance tips #24987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If all CIs pass it's almost too good to be true, and we should start considering if this is all just a dream. |
ararslan
added
docs
|
Any reason this was never merged? Is this advice still relevant? |
|
Ping: https://discourse.julialang.org/t/call-overhead-of-keyword-args/17380/2?u=mschauer |
|
There are still some slow cases, but they're much rarer and subtler, e.g. splatting a Dict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the results of the newest keyword argument changes:
#24795 (comment)
Could this section be entirely erased from the performance tips?
https://docs.julialang.org/en/latest/manual/performance-tips/#Declare-types-of-keyword-arguments-1