Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inference: improve edges #24337

Merged
merged 3 commits into from
Nov 6, 2017
Merged

inference: improve edges #24337

merged 3 commits into from
Nov 6, 2017

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 25, 2017

previously bestguess might be Conditional, which was very bad
also, I think there was a missing call to update_valid_age! in some cases?

@vtjnash vtjnash added backport pending 0.6 bugfix This change fixes an existing bug labels Oct 25, 2017
@martinholters
Copy link
Member

Any way this could be tested?

@vtjnash
inference: improve edges
d9bb51a 
previously bestguess might be Conditional, which was very bad
also, I think there was a missing call to update_valid_age!
@vtjnash
inference: limit recursion less strongly
ca2cdd2 
This seems to give better results for most code (especially base).
It means we can't cache the results, but that doesn't seem to be necessary
(we weren't doing it before either)
@vtjnash
inference: fix cycle resolution caching
86aefe8
@vtjnash vtjnash mentioned this pull request Oct 27, 2017
Merged
@JeffBezanson JeffBezanson added the compiler:inference Type inference label Oct 29, 2017
@JeffBezanson JeffBezanson mentioned this pull request Nov 2, 2017
Closed
@vtjnash vtjnash merged commit 28dc9d3 into master Nov 6, 2017
@vtjnash vtjnash deleted the jn/inference-edges branch November 6, 2017 17:38
@ararslan
Copy link
Member

ararslan commented Nov 7, 2017

This doesn't seem to backport very cleanly to release-0.6. Would you be willing to make a PR for this change against release-0.6?

@JeffBezanson
Copy link
Member

My impression is only the couple small items mentioned in the OP are eligible for backporting:

previously bestguess might be Conditional, which was very bad
also, I think there was a missing call to update_valid_age! in some cases?

@StefanKarpinski
Copy link
Member

@vtjnash, can you please prepare a PR of the parts of this that are actually backportable?

vtjnash added a commit that referenced this pull request Nov 8, 2017
@vtjnash
inference: improve edges
316ffb8 
previously bestguess might be Conditional, which was very bad
also, I think there was a missing call to update_valid_age!

(cherry picked from commit d9bb51a, PR #24337)
vtjnash added a commit that referenced this pull request Nov 8, 2017
@vtjnash
inference: fix cycle resolution caching
e881f64 
(cherry picked from commit 86aefe8, PR #24337)
ararslan pushed a commit that referenced this pull request Nov 17, 2017
@vtjnash @ararslan
inference: improve edges
d3fbfa1 
previously bestguess might be Conditional, which was very bad
also, I think there was a missing call to update_valid_age!

(cherry picked from commit d9bb51a, PR #24337)
ararslan pushed a commit that referenced this pull request Nov 17, 2017
@vtjnash @ararslan
inference: fix cycle resolution caching
f25cc60 
(cherry picked from commit 86aefe8, PR #24337)
@ararslan ararslan mentioned this pull request Nov 20, 2017
Merged
@vtjnash vtjnash mentioned this pull request Oct 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:inference Type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vtjnash @martinholters @ararslan @JeffBezanson @StefanKarpinski