Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWS: doc removal of include_from_node1 #22876

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jul 19, 2017

NEWS and doc updates for PR #22588. I couldn't find many places in the docs that talked about include_from_node1 behavior existing, so let me know if you know of or find any others.

@vtjnash vtjnash requested a review from tkelman July 19, 2017 20:47
NEWS.md Outdated
@@ -63,6 +63,11 @@ This section lists changes that do not have deprecation warnings.
* The `Diagonal` type definition has changed from `Diagonal{T}` to
`Diagonal{T,V<:AbstractVector{T}}` ([#22718]).

* On a cluster, all files are now loaded from the local file system rather than node 1 ([#22588]).
To load the same file everywhere from node 1, one possible alternative is to broadcast a call to `include_string`:
`@everywhere include_string(Main, $(read("filename", String)), "filename")`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need @eval?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Why would it? include_string should be equivalent to eval?

@kshyatt kshyatt added docs This change adds or pertains to documentation parallelism Parallel or distributed computation labels Jul 20, 2017
@vtjnash vtjnash merged commit 105cdb8 into master Jul 21, 2017
@vtjnash vtjnash deleted the jn/no-node1-include-docs branch July 21, 2017 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation parallelism Parallel or distributed computation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants