Use Symbol for uplo in Bidiagonal constructors #22703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
force-pushed
the
fe/bidiag-constr
branch
4 times, most recently
from
b1c0a33
to
d0deabd
Compare
KristofferC
reviewed
Jul 7, 2017
NEWS.md
Outdated
| @@ -136,6 +136,9 @@ Deprecated or removed | |||
| * The method `replace(s::AbstractString, pat, r, count)` with `count <= 0` is deprecated | |||
| in favor of `replace(s::AbstractString, pat, r, typemax(Int))` ([#22325]). | |||
|
|
|||
| * `Bidiagonal` constructors have been re-factored to use a `Symbol` for the upper/lower | |||
There was a problem hiding this comment.
"have been re-factored to" -> "now"?
fredrikekre
force-pushed
the
fe/bidiag-constr
branch
from
d0deabd
to
42d19c4
Compare
|
AV is the libgit2 failure. |
fredrikekre
force-pushed
the
fe/bidiag-constr
branch
from
42d19c4
to
7f9d324
Compare
|
Rebased. |
- Consistent with Symmetric/Hermitian wrappers - It is clearer to use :U/:L instead of true/false - The Char constructor was originally for internal use only; remove and remove docstring
fredrikekre
force-pushed
the
fe/bidiag-constr
branch
from
7f9d324
to
cc96e65
Compare
KristofferC
approved these changes
Jul 10, 2017
fredrikekre
commented
Jul 10, 2017
| Bidiagonal(dv::AbstractVector{T}, ev::AbstractVector{T}, isupper::Bool) where {T} = Bidiagonal{T}(collect(dv), collect(ev), isupper) | ||
| function Bidiagonal(dv::AbstractVector{T}, ev::AbstractVector{T}, uplo::Symbol) where T | ||
| Bidiagonal{T}(collect(dv), collect(ev), char_uplo(uplo)) | ||
| end | ||
| Bidiagonal(dv::AbstractVector, ev::AbstractVector) = throw(ArgumentError("did you want an upper or lower Bidiagonal? Try again with an additional true (upper) or false (lower) argument.")) |
There was a problem hiding this comment.
Woops, missed to update this one. Can we just remove this method? IMO a MethodError is better:
julia> Bidiagonal(a, b)
ERROR: MethodError: no method matching Bidiagonal(::Array{Float64,1}, ::Array{Float64,1})
Closest candidates are:
Bidiagonal(::Array{T,1}, ::Array{T,1}, ::Char) where T at linalg/bidiag.jl:15
Bidiagonal(::AbstractArray{T,1}, ::AbstractArray{T,1}, ::Symbol) where T at linalg/bidiag.jl:59
Bidiagonal(::AbstractArray{Td,1}, ::AbstractArray{Te,1}, ::Symbol) where {Td, Te} at linalg/bidiag.jl:64
jeffwong
pushed a commit
to jeffwong/julia
that referenced
this pull request
Jul 24, 2017
- Consistent with Symmetric/Hermitian wrappers - It is clearer to use :U/:L instead of true/false - The Char constructor was originally for internal use only; remove and remove docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symmetric/Hermitianwrappers:U/:Linstead oftrue/falseCharconstructor was originally for internal use only; remove and remove docstring