Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEWS for to_indices (#19730) #22152

Merged
merged 3 commits into from
Jun 6, 2017
Merged

NEWS for to_indices (#19730) #22152

merged 3 commits into from
Jun 6, 2017

Conversation

mbauman
Copy link
Member

@mbauman mbauman commented May 31, 2017

Cc @Sacha0

@Keno
Copy link
Member

Keno commented May 31, 2017

Should target 0.6?

Sacha0
Sacha0 reviewed Jun 1, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @Mbuman! :)

Perhaps the specific breaking changes and deprecations are worth mentioning as well? And running NEWS-update.jl to link the PR?

@tkelman
Copy link
Contributor

tkelman commented Jun 1, 2017 •
edited
Loading

Should target 0.6?

yep, this is currently adding to the 0.7 section of the file, should move it down to the 0.6 section nevermind I misread that

@mbauman
Add notes about colon deprecations, logical indices, …
fbc3dc1 
and CartesianIndex performance improvements.
@mbauman
Copy link
Member Author

mbauman commented Jun 4, 2017

I've added a few sub-points that help explain the changes a bit more in depth.

tkelman
tkelman reviewed Jun 4, 2017
View reviewed changes
NEWS.md Outdated
   As a result, the type of `SubArray`s that represent views over colon indices has changed.

+ Logical indexing is now more efficient. Logical arrays are converted by `to_indices` to
a lazy, iterative collection of indices that doesn't support indexing. A deprecation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iterative or iterable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sacha0
Sacha0 approved these changes Jun 4, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks @mbauman! :)

@Sacha0
Copy link
Member

Sacha0 commented Jun 5, 2017

Absent objections, requests for time, or someone beating me to it, I plan to merge this tomorrow morning. Best!

@Sacha0 Sacha0 merged commit 91f08bb into master Jun 6, 2017
@KristofferC KristofferC deleted the mb/news19730 branch June 6, 2017 20:34
@Sacha0
Copy link
Member

Sacha0 commented Jun 8, 2017

(Ref. #21475.)

tkelman pushed a commit that referenced this pull request Jun 17, 2017
@mbauman @tkelman
NEWS for to_indices (#19730) (#22152)
3fb6535 
* NEWS for to_indices (#19730)
(cherry picked from commit 91f08bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbauman @Keno @tkelman @Sacha0