Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broadcast_indices #22130

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Fix broadcast_indices #22130

merged 1 commit into from
Jun 1, 2017

Commits on May 30, 2017

  1. Fix broadcast_indices

    This fixes a regression introduced in 4f1b479. broadcast_indices() needs to
    be overloaded by packages for custom types, so it cannot be hidden under
    _broadcast_indices(). Also, ::Type is incorrect since the method only applies
    to scalars.
    
    Make the tests more complex to be closer to actual implementations in packages
    so that regressions like this will be noticed in the future.
    nalimilan committed May 30, 2017
    Configuration menu
    Copy the full SHA
    8123644 View commit details
    Browse the repository at this point in the history