Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: documentation improvements #2147

Closed
wants to merge 12 commits into from
Closed

WIP: documentation improvements #2147

wants to merge 12 commits into from

Conversation

dirk
Copy link
Member

@dirk dirk commented Jan 27, 2013

Have some free time right now so I'm working on improving the documentation. Please let me know if there are any specific functions/modules/etc. that have been updated/added that need documenting!

NOTE: This also now includes a small fix to the TextMate bundle to include a capture for nothing, true, false, etc.

@stevengj
Copy link
Member

See #2145 : it would be good to note that ccall supports structs, and that Complex64 and Complex128 arguments passed/returned by value (but not as arrays or otherwise by reference) should use ComplexPair{Float32} and ComplexPair{Float64}, respectively.


Create an arbitrary precision floating point number. ``x`` may be an ``Integer``, a ``Float64``, a ``String`` or a ``BigInt``. The
usual mathematical operators are defined for this type, and results are promoted to a ``BigFloat``.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. Thanks for pointing that out! I'll add them back in.

@dirk
Copy link
Member Author

dirk commented Jan 31, 2013

@stevengj Thanks for the suggestions. I'll work on that tonight.

@stevengj
Copy link
Member

Another documentation omission if you are in the mood: #2159.

@kmsquire
Copy link
Member

kmsquire commented Feb 7, 2013

Hi Dirk, if you're still working on this:

  • doc/manual/sparse-matrices.rst needs to be included in index.rst
  • sorting has recently gone through a major overhaul, most of the specialized sorting functions no longer exist and should be removed from the documentation. The signatures of the sort functions themselves have also changed somewhat.
  • if you have the proper tools installed, you could regenerate the help database with cd doc; make helpdb.jl, and add it to the commit.

Cheers!

@ViralBShah
Copy link
Member

I tried to make sparse matrices a part of arrays - but was not too successful at it.

@kmsquire
Copy link
Member

kmsquire commented Feb 7, 2013

If you update the sort docs, @StefanKarpinski should know. There may be some additional changes coming up.

@dirk
Copy link
Member Author

dirk commented Feb 7, 2013

@kmsquire: I'll update the sort docs and look into sparse matrices too.

@kmsquire
Copy link
Member

kmsquire commented Feb 8, 2013

Thanks!

@timholy
Copy link
Member

timholy commented Feb 12, 2013

Wow, this is impressive.

I doubt we should bikeshed this, it seems so clearly an improvement that perhaps we should just take it and deal with problems later?

@JeffBezanson
Copy link
Member

Sorry, we collided a bit.

JeffBezanson pushed a commit that referenced this pull request Feb 13, 2013
@kmsquire
Copy link
Member

I got the basic information for the sort docs done (#2291, #2294).

You might consider renaming this to RFC, so that it gets considered for the 0.1 release (though it might be too late for that), and then start another pull if you plan to work on the docs more. Thanks for working on this!

@timholy timholy closed this in bf3eccf Feb 15, 2013
@timholy
Copy link
Member

timholy commented Feb 15, 2013

@dirk, I made some changes. In particular, there were some places, e.g., iterable{Type} where I did not think the extra information actually clarified the meaning. So I deleted those, hope that's OK.

@dirk
Copy link
Member Author

dirk commented Feb 15, 2013

@timholy Yeah, no problem! Thanks for getting this merged in.

I'm going to keep chipping away on this and #2242. So it'll probably be reopened in a little with some more commits if that's alright.

@pao
Copy link
Member

pao commented Feb 15, 2013

@dirk, you'll probably be better off rebasing on master on or after bf3eccf, then opening a new pull request.

@timholy
Copy link
Member

timholy commented Feb 15, 2013

Please open as a new pull request against fresh master. It took me quite a
long time to clean this up, I wouldn't want to have to go through it again.

@dirk
Copy link
Member Author

dirk commented Feb 15, 2013

@timholy & @pao: Will do. Sorry about all the cleanup you had to do. Know that pain from having to merge edits to the docs while I was working on this.

@timholy
Copy link
Member

timholy commented Feb 15, 2013

@dirk, I'm no git expert, but my impression is that unless you think someone will branch off your tree, you can update your pull request by rebasing your commits against a fresh master and doing a force push to your public repository. Others should contradict this if it is bad advice.

@dirk
Copy link
Member Author

dirk commented Feb 15, 2013

@timholy: Yeah that's what I've been trying to do. But there were some other edits to doc/base.rst here and there that got pushed to master while I was working so I still had to do some pesky merges.

@pao
Copy link
Member

pao commented Feb 15, 2013

Sometimes the best thing to do is rebuild the patches back onto master:

$ git branch mybranch-backup
$ git reset origin/master #assuming JuliaLang/julia is origin
$ git add -p #stage the parts of your first patch
$ git commit
$ git add -p #stage the parts of your second patch
$ git commit
...
$ git push -f mine HEAD #to push your cleanly-applicable patch queue to your fork

@dirk
Copy link
Member Author

dirk commented Feb 15, 2013

@pao: Gotcha, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants