-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: documentation improvements #2147
Conversation
See #2145 : it would be good to note that |
|
||
Create an arbitrary precision floating point number. ``x`` may be an ``Integer``, a ``Float64``, a ``String`` or a ``BigInt``. The | ||
usual mathematical operators are defined for this type, and results are promoted to a ``BigFloat``. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. Thanks for pointing that out! I'll add them back in.
@stevengj Thanks for the suggestions. I'll work on that tonight. |
Another documentation omission if you are in the mood: #2159. |
Hi Dirk, if you're still working on this:
Cheers! |
I tried to make sparse matrices a part of arrays - but was not too successful at it. |
If you update the sort docs, @StefanKarpinski should know. There may be some additional changes coming up. |
@kmsquire: I'll update the sort docs and look into sparse matrices too. |
Thanks! |
Wow, this is impressive. I doubt we should bikeshed this, it seems so clearly an improvement that perhaps we should just take it and deal with problems later? |
Sorry, we collided a bit. |
Conflicts: doc/stdlib/base.rst
@dirk, I made some changes. In particular, there were some places, e.g., |
Please open as a new pull request against fresh master. It took me quite a |
@dirk, I'm no git expert, but my impression is that unless you think someone will branch off your tree, you can update your pull request by rebasing your commits against a fresh master and doing a force push to your public repository. Others should contradict this if it is bad advice. |
@timholy: Yeah that's what I've been trying to do. But there were some other edits to doc/base.rst here and there that got pushed to master while I was working so I still had to do some pesky merges. |
Sometimes the best thing to do is rebuild the patches back onto master:
|
@pao: Gotcha, will do. |
Have some free time right now so I'm working on improving the documentation. Please let me know if there are any specific functions/modules/etc. that have been updated/added that need documenting!
NOTE: This also now includes a small fix to the TextMate bundle to include a capture for
nothing
,true
,false
, etc.