document that srand() returns the passed RNG #21248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
docs
StefanKarpinski
approved these changes
Apr 3, 2017
|
Thanks for the review, I will merge in a couple of days if no objection comes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Till now this behavior was very useful as the shortest way to get a randomly seeded RNG was
r = srand(MersenneTwister()). This could change in the future (cf. #16984), but I still think this will be a desirable feature (which was introduced in 68049d4, but not systematically).Also, this PR documents the optional argument of
srandwhen seeding from a file.