Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 0.5 syntax deprecation warnings #20327

Merged
merged 3 commits into from
Feb 5, 2017
Merged

remove 0.5 syntax deprecation warnings #20327

merged 3 commits into from
Feb 5, 2017

Conversation

JeffBezanson
Copy link
Member

This handles front-end-related syntax deprecations. A helpful "TODO" reminds us that we now have the option of parsing => as a call (like other normal operators) instead of as its own expression head. I could go either way; it's nicer but could break some macros.

@JeffBezanson JeffBezanson added this to the 0.6.0 milestone Jan 30, 2017
@StefanKarpinski
Copy link
Member

+1 to parsing it as a normal call. Fewer special cases will make future macro writers happier.

@ararslan ararslan added deprecation This change introduces or involves a deprecation parser Language parsing and surface syntax labels Jan 30, 2017
@JeffBezanson
Copy link
Member Author

Commit added for that.

@vtjnash vtjnash added the needs tests Unit tests are required for this change label Jan 31, 2017
@JeffBezanson
Copy link
Member Author

@vtjnash What do you want tests for --- parsing of =>, or something else as well?

@JeffBezanson
Copy link
Member Author

Note from triage: tests needed for the new (corrected) meaning of previously-deprecated :: syntax.

@vtjnash
Copy link
Member

vtjnash commented Feb 2, 2017

mostly just testing for the meaning of type declarations

@tkelman tkelman removed the needs tests Unit tests are required for this change label Feb 2, 2017
@JeffBezanson JeffBezanson merged commit 7aab89d into master Feb 5, 2017
@tkelman tkelman deleted the jb/rmsyntaxdeps branch February 5, 2017 18:27
tkelman referenced this pull request in lopezm94/SugarBLAS.jl Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This change introduces or involves a deprecation parser Language parsing and surface syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants