Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to Customizing Colors section #20240

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

TotalVerb
Copy link
Contributor

I found the linked documentation in the NEWS not very informative. This change introduces more explanation for what exactly to do to make answer colors bold, which I anticipate is the most frequent color customization.

@TotalVerb
Copy link
Contributor Author

I don't understand the appveyor failure, but I doubt it is related.

@tkelman
Copy link
Contributor

tkelman commented Jan 27, 2017

#16555

@KristofferC
Copy link
Member

Isn't it easier to use ENV["JULIA_ANSWER_COLOR"] = :bold

@TotalVerb
Copy link
Contributor Author

I didn't see where that was documented.

@KristofferC
Copy link
Member

Hmm you are right, it doesn't seem to be documented. There is a PR that does it though #20162

@TotalVerb
Copy link
Contributor Author

Note that this change, beyond giving an example of making colors bold, also improves the documentation of what and where .juliarc is. So I think that we should make this change in addition to #20162.

@TotalVerb
Copy link
Contributor Author

Bump. I still think this is an improvement over the existing (mostly lack of) documentation.

@TotalVerb
Copy link
Contributor Author

Good to go?

Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absent objections, requests for time, or someone else beating me to it, I plan to merge this tomorrow afternoon. Best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants