Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix demangling of inlined frames to not depend on linfo lookup #20218

Merged
merged 1 commit into from
Jan 27, 2017

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jan 24, 2017

No description provided.

@StefanKarpinski
Copy link
Member

Hard to know what this changes or if it's correct since it doesn't have tests. Is it possible to test? If not that's ok, but I think in that case only @vtjnash is in a position to decide if it's ready or not.

@tkelman
Copy link
Contributor

tkelman commented Jan 27, 2017

The fixing of the semicolon, and possibly the fromC flag, should address the issue that was causing #19890 to fail its tests on win32, though that PR causes large performance regressions that we will need to address before merging it.

The deletion here of jlsysw_ etc seems mostly unrelated to the rest of what it's doing though?

@vtjnash
Copy link
Member Author

vtjnash commented Jan 27, 2017

This is hard to test, since it's checking the case where debug info is missing or bad, and we generally try not to do that. The deletion of jlsysw there is because I noticed that its almost dead code (this code path is supposed to be uniform with the other ~3 that compute the same heuristics), but won't actually compute the right set of values if (when) it can get triggered.

@vtjnash vtjnash merged commit 8091c21 into master Jan 27, 2017
@vtjnash vtjnash deleted the jn/inline-demangle branch January 27, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants