RFC: Document the rationale behind * for strings #19643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| as in Perl: | ||
| Julia also provides `*` for string concatenation: | ||
|
|
||
| ```julia |
There was a problem hiding this comment.
Probably worth starting to re-add jldoctests when new examples are added; it can be done bit by bit for anything in manual/. Since this one uses variables from the above block you'll need to use named blocks, i.e.
```jldoctest my-name-here
to share a namespace between each code block.
There was a problem hiding this comment.
Okay, I've changed the string concatenation code blocks to jldoctests under a single namespace. Thanks! (And I've not added [ci skip] to this commit in order to trigger CI. The text in the previous commit can be removed on squash-merge.)
|
This is really nice! |
|
I wish you had spent your valuable time introducing another operator (like |
kshyatt
added
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured as long as
*is used for string concatenation, we should be transparent about why it's used for string concatenation. Currently it's not even mentioned in the manual, only in the standard library documentation. This PR adds a subsection on concatenation to the Strings section of the manual. In it I've tried to express why*isn't just some arbitrary choice. In its current form, the text here was built collaboratively by @Sacha0 and me. Any comments are quite welcome.As an aside, since this only touches a Markdown file in the manual source, I've skipped CI. If CI should not have been skipped then let me know and I can undo that.
cc @stevengj and @StefanKarpinski