Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update travis xcode version #19475

Merged
merged 1 commit into from
Dec 3, 2016
Merged

update travis xcode version #19475

merged 1 commit into from
Dec 3, 2016

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Dec 1, 2016

SIP prevents the DYLD variables from being passed to make via the environment
so pass it via the arguments instead

@kshyatt kshyatt added system:mac Affects only macOS testsystem The unit testing framework and Test stdlib labels Dec 1, 2016
@ararslan
Copy link
Member

ararslan commented Dec 1, 2016

I'll close my PR for this then. Thanks!

@staticfloat
Copy link
Member

Good catch @vtjnash, thanks for looking into this.

@yuyichao
Copy link
Contributor

yuyichao commented Dec 2, 2016

Somehow still the same error?

@vtjnash
Copy link
Member Author

vtjnash commented Dec 2, 2016

I forgot a semicolon

@vtjnash vtjnash force-pushed the jn/travis-xcode branch 3 times, most recently from 84424cd to 6c082f5 Compare December 3, 2016 03:18
brew install -v cmake staticfloat/juliadeps/libgfortran;
brew install -v --only-dependencies --HEAD julia;
brew install cmake staticfloat/juliadeps/libgfortran;
brew install --only-dependencies --HEAD julia;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when this fails we will want to know why, please put this back

@vtjnash vtjnash force-pushed the jn/travis-xcode branch 3 times, most recently from fde570b to f6cd0c1 Compare December 3, 2016 14:32
SIP prevents the DYLD variables from being passed to make via the environment
so pass it via the arguments instead
@ararslan
Copy link
Member

ararslan commented Dec 3, 2016

Looks like you got it! Nice work! 💯

@vtjnash
Copy link
Member Author

vtjnash commented Dec 3, 2016

Yay! Finally got the syntax right to make bash happy. Thanks for the original PR too, it helped with the debugging.

@vtjnash vtjnash merged commit df2053c into master Dec 3, 2016
@vtjnash vtjnash deleted the jn/travis-xcode branch December 3, 2016 22:30
@vtjnash vtjnash restored the jn/travis-xcode branch December 3, 2016 22:39
@vtjnash vtjnash deleted the jn/travis-xcode branch December 3, 2016 22:39
@vtjnash vtjnash added backport pending 0.5 building Build system, or building Julia or its dependencies labels Dec 3, 2016
make $BUILDOPTS -C contrib -f repackage_system_suitesparse4.make;
TESTSTORUN="all --skip linalg/triangular subarray"; fi # TODO: re enable these if possible without timing out
- git clone -q git://git.kitenet.net/moreutils
script:
- echo $BUILDOPTS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't necessary to have in all build logs

- make -C moreutils mispipe
- make $BUILDOPTS -C base version_git.jl.phony
# capture the log, but only print it if `make deps` fails
# try to show the end of the log first, because this log might be very long (> 4MB)
# and thus be truncated by travis
- moreutils/mispipe "make $BUILDOPTS VERBOSE=0 -C deps 2> deps-err.log" "$BAR" > deps.log ||
- moreutils/mispipe "make \$BUILDOPTS VERBOSE=0 -C deps 2> deps-err.log" "$BAR" > deps.log ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't work, it prevents parallel builds

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? how? this is critical for ensuring that the interpolation happens at the right time for the macOS build to succeed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildopts is getting ignored completely at this step. no interpolation is needed at this step, the deps don't need the redefinition of spawn. between merging this pr and my partial reversion of it it was impossible to rebuild from a fresh cache without timing out, due to building all deps in serial and building two copies of llvm (one with assertions and one without). this was broken, clean cache builds do go through in time now with it partially reverted

vtjnash added a commit that referenced this pull request Feb 7, 2017
SIP prevents the DYLD variables from being passed to make via the environment
so pass it via the arguments instead

(cherry picked from commit 156edb4, PR #19475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies system:mac Affects only macOS testsystem The unit testing framework and Test stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants