Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove full from similar(full(X), T, dims) calls in generic concatenation methods #17660

Merged
merged 1 commit into from
Oct 8, 2016
Merged

Remove full from similar(full(X), T, dims) calls in generic concatenation methods #17660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions base/abstractarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,7 +1014,7 @@ function typed_vcat{T}(::Type{T}, V::AbstractVector...)
for Vk in V
n += length(Vk)
end
a = similar(full(V[1]), T, n)
a = similar(V[1], T, n)
pos = 1
for k=1:length(V)
Vk = V[k]
Expand Down Expand Up @@ -1042,7 +1042,7 @@ function typed_hcat{T}(::Type{T}, A::AbstractVecOrMat...)
nd = ndims(Aj)
ncols += (nd==2 ? size(Aj,2) : 1)
end
B = similar(full(A[1]), T, nrows, ncols)
B = similar(A[1], T, nrows, ncols)
pos = 1
if dense
for k=1:nargs
Expand Down Expand Up @@ -1074,7 +1074,7 @@ function typed_vcat{T}(::Type{T}, A::AbstractMatrix...)
throw(ArgumentError("number of columns of each array must match (got $(map(x->size(x,2), A)))"))
end
end
B = similar(full(A[1]), T, nrows, ncols)
B = similar(A[1], T, nrows, ncols)
pos = 1
for k=1:nargs
Ak = A[k]
Expand Down Expand Up @@ -1303,7 +1303,7 @@ function typed_hvcat{T}(::Type{T}, rows::Tuple{Vararg{Int}}, as::AbstractMatrix.
a += rows[i]
end

out = similar(full(as[1]), T, nr, nc)
out = similar(as[1], T, nr, nc)

a = 1
r = 1
Expand Down