fix llvm patch repeat application issue #17592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependency on configure should be order-only (after the `|`) since a patch modifies the file. also use CMakeLists.txt since llvm's configure will be going away
tkelman
added a commit
that referenced
this pull request
Jul 26, 2016
No rule to make target CMakeLists.txt in a clean build, my bad
|
Oops, this breaks from-scratch builds. fix in c31c5f6 |
|
sigh, this is going to cause a lot of bad builds :( The problem being that CMakeFiles.txt was older than the tgz archive, so we're going to re-extract it on top of the existing files. Then we're mostly not going to patch them, because we think we already did... |
|
Ah, crap, that's what it was. Makes sense now. Sure would've been nice if you'd reviewed this. I also should have done more extensive local tests. |
|
Sorry, I had looked at this but missed that. I'll push a hotfix shortly. |
|
c31c5f6 seems okay but needs people to do |
vtjnash
added a commit
that referenced
this pull request
Jul 29, 2016
re-extraction of a tarball doesn't properly re-apply patches for llvm this patch will force everyone to get a rebuild of a properly patched llvm
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
dependency on configure should be order-only (after the `|`) since a patch modifies the file. also use CMakeLists.txt since llvm's configure will be going away
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
No rule to make target CMakeLists.txt in a clean build, my bad
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
re-extraction of a tarball doesn't properly re-apply patches for llvm this patch will force everyone to get a rebuild of a properly patched llvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency on configure should be order-only (after the
|)since a patch modifies the file. also use CMakeLists.txt since
llvm's configure will be going away
cc @ViralBShah