Make median non-mutating on arrays.
#17154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How many more of these might there be? |
|
This is the only call to |
|
#16091 strikes again?
|
|
|
|
Passing a mutating function to a higher-order function is always a big red flag. It happens here because this is a strange case where the function returns a new result, but is allowed to overwrite its input. |
ranjanan
added a commit
to ranjanan/julia
that referenced
this pull request
Jun 28, 2016
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
…17164) * Add test for Issue JuliaLang#17153 and PR JuliaLang#17154 * Fix whitespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in the behaviour of
mapslices(#16260),median(X,k)would mutate the underlying array. Fixes #17153.