WIP: Throw UnicodeError for s[i:j], where j is not at the start of a code point #14217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,26 +101,33 @@ sizeof(s::UTF8String) = sizeof(s.data) | |||
|
|
|||
| lastidx(s::UTF8String) = length(s.data) | |||
|
|
|||
| isfirstbyte(c::UInt8) = (c & 0xc0) != 0x80 # == !is_valid_continuation(c) | |||
There was a problem hiding this comment.
@code_llvm says that !is_valid_continuation(c) compiles to code identical to firstbyte(c), so I don't think we need a separate firstbyte function.
There was a problem hiding this comment.
I wasn't sure if it would be optimised to the same code, thanks for the clarification. For me it also aids readability, but I'm happy to remove.
JobJob
force-pushed
the
jj/utf8strictidx
branch
from
3ca28d3
to
a22a2d4
Compare
JobJob
changed the title
code point Plus a few tests fixes JuliaLang#14158
adds UTF16 getindex Fixes chop and date format parsing more tests improves Unicode invalid index error message
JobJob
force-pushed
the
jj/utf8strictidx
branch
from
8043f6d
to
7721cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if j was in the middle of a code point then it was moved to the end of the code point to be more forgiving. After discussion with @stevengj and @nalimilan in #14158 the recommendation was it would be more sensible to throw an error.
Also added some more tests.