Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process and pipe cleanup #12739

Merged
merged 15 commits into from
Aug 26, 2015
Merged

process and pipe cleanup #12739

merged 15 commits into from
Aug 26, 2015

Commits on Aug 22, 2015

  1. Make it possible again to read STDERR without calling cat 

    Merge the Pipe() and Pipe(C_NULL) constructors having the former just
call the latter and delaying initialization to the place where it is
actually needed. Now passing an empty Pipe to spawn will once again
initialize it with the appropriate pipe end.
    @Keno @vtjnash
    Keno authored and vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    771ec0b View commit details
    Browse the repository at this point in the history

  2. Rename pipe -> pipeline

    @Keno @vtjnash
    Keno authored and vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    0c17088 View commit details
    Browse the repository at this point in the history

  3. Remove a test that no longer tests what it thinks it tests

    @Keno @vtjnash
    Keno authored and vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    a8a2e6d View commit details
    Browse the repository at this point in the history

  4. fix spawn test to call readall before waiting for the process to exit… 

    …. also rename Pipe to PipeEndpoint
    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    8206f9f View commit details
    Browse the repository at this point in the history

  5. create a new Pipe type that represents an entire pipeline

    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    6b223a3 View commit details
    Browse the repository at this point in the history

  6. add a few definitions to DevNullStream

    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    6030f7e View commit details
    Browse the repository at this point in the history

  7. redesign Process to be a subtype of IO and dispatch read/write to the… 

    … appropriate stdin/stdout stream
    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    80be437 View commit details
    Browse the repository at this point in the history

  8. fix permission bits for stdio file open on *nix

    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    18d646f View commit details
    Browse the repository at this point in the history

  9. add enough methods to AbstractPipe to get the tests to pass

    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    2ff0c54 View commit details
    Browse the repository at this point in the history

  10. now that we have named arguments, ProcessChainOrNot can finally becom… 

    …e a hidden argument rather than an awkward first argument
    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    fd40e79 View commit details
    Browse the repository at this point in the history

  11. fix tests broken by open(cmd)=>Process change

    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    9f43cef View commit details
    Browse the repository at this point in the history

  12. always use Pipe, not PipeEndpoint, in spawn 

    PipeEndpoint has behavioral flaws when used on its own since it is incapable of tracking the full pipe and the behavior of both ends
    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    dc03fbb View commit details
    Browse the repository at this point in the history

  13. make Cmd objects immutable 

    overdue so long
    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    1481981 View commit details
    Browse the repository at this point in the history

  14. Process.exitcode needs to be an Int64 to cover the range typemin(Int3… 

    …2):typemax(UInt32) that may be returned by spawn on windows (fixes #12176)
    @vtjnash
    vtjnash committed Aug 22, 2015
    Configuration menu
    Copy the full SHA
    c565cd0 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2015

  1. Revert open(cmd) => Process change 

    for separation into a independent merge commit
    @vtjnash
    vtjnash committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    8ffdfc2 View commit details
    Browse the repository at this point in the history