fix #12552 (norm should return NaN for NaN inputs) #12564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sqrt(big(NaN))
This was referenced Aug 11, 2015
stevengj
added a commit
that referenced
this pull request
Aug 11, 2015
fix #12552 (norm should return NaN for NaN inputs)
stevengj
added a commit
that referenced
this pull request
Oct 20, 2015
stevengj
added a commit
that referenced
this pull request
Oct 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal fix for #12552 that does not require a decision on #7866.
In the infinity norms, we don't have to worry about signed zeros because we are taking absolute values. So, it is optimal anyway just to inline our own
maxandminfunctions that ignore the sign bit, and once we are doing that we can treat NaN however we want for these functions.In doing so, I noticed and fixed a bug that
sqrt(big(NaN))was throwing aDomainErrorrather than returning NaN.