-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill out linalg tests #12095
Fill out linalg tests #12095
Conversation
A long lived one. I made that error in March 2013. We should (again) consider saving the symmetric and general eigensolutions as separate types. It is a shame to invert the vectors when you know that the problem is symmetric, but that is for another pr. Thanks for fixing this. |
Looks like I got hit by the AppVeyor timeout. Everyone ok with this change? |
Nice find. I think given its passing on travis, should be good to merge. |
But, but, #12086 (comment). Also I think this PR really demonstrates the value of getting files to 100% coverage, considering |
Figuring out how to get to 100% coverage is definitely something we should do. |
restarted, passing now agreed with @andreasnoack that symmetric/hermitian eigenproblems should probably be a different type than nonsymmetric some day |
I found a bug in taking the inverse of an
Eigen
which is hopefully fixed now. I also added tests to get some ofbase/linalg
to 100% coverage.