Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate utf16_is_*, utf16_get_supplementary, is_utf8_*, add @unexportedwarning macro, add tests #11976

Closed
wants to merge 5 commits into from
Closed

Deprecate utf16_is_*, utf16_get_supplementary, is_utf8_*, add @unexportedwarning macro, add tests #11976

wants to merge 5 commits into from

Commits on Aug 8, 2015

  1. Deprecate utf16_is_* and utf16_get_supplementary functions 

    These functions were undocumented and unexported, and were not generic.
They have been replaced by other, generic functions, that will work on unsigned values of any size.
Although it is not normal to have to deprecate unexported functions, these are being used in some packages (notably JSON.jl, which is used by many other packages)
    @ScottPJones
    ScottPJones committed Aug 8, 2015
    Configuration menu
    Copy the full SHA
    6cd9ba6 View commit details
    Browse the repository at this point in the history

  2. depwarn instead of deprecate

    @ScottPJones
    ScottPJones committed Aug 8, 2015
    Configuration menu
    Copy the full SHA
    abfe2e3 View commit details
    Browse the repository at this point in the history

  3. Deprecate is_utf8_start is_utf8_continuation

    @ScottPJones
    ScottPJones committed Aug 8, 2015
    Configuration menu
    Copy the full SHA
    b724bc7 View commit details
    Browse the repository at this point in the history

  4. Add @unexportedwarn macro, to add unexported deprecation warning 

    This will allow people to easily deprecate functions that were supposed to be private,
but got used in packages (like Base.indentation, Base.unindent, Base.is_utf_start, etc.)
    @ScottPJones
    ScottPJones committed Aug 8, 2015
    Configuration menu
    Copy the full SHA
    4ee002e View commit details
    Browse the repository at this point in the history

  5. Test is_utf8_start is_utf8_continuation deprecations

    @ScottPJones
    ScottPJones committed Aug 8, 2015
    Configuration menu
    Copy the full SHA
    4381c3a View commit details
    Browse the repository at this point in the history