Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up argument processing order #10713

Merged
merged 2 commits into from
Apr 2, 2015
Merged

clean up argument processing order #10713

merged 2 commits into from
Apr 2, 2015

Conversation

JeffBezanson
Copy link
Member

  • load juliarc very early, before start_worker or starting processes
  • load juliarc in only one place
  • handle -L after starting workers, like the help says
  • shorten some of the code

see #10692

- load juliarc very early, before start_worker or starting processes
- load juliarc in only one place
- handle -L after starting workers, like the help says
- shorten some of the code
@jakebolewski
Copy link
Member

@tkelman do you know why this causes the Windows tests to consistently fail? I have a follow up quick fix that addresses #10226.

@tkelman
Copy link
Contributor

tkelman commented Apr 2, 2015

Yeah, programs that the spawn tests are calling live in Git/bin which gets added to the path by juliarc https://github.com/JuliaLang/julia/blob/master/contrib/windows/juliarc.jl so evidently that isn't happening early enough or at all here?

@JeffBezanson
Copy link
Member Author

Ah, maybe I want

startup               = (opts.startupfile != 2)

instead?

jakebolewski added a commit that referenced this pull request Apr 2, 2015
@jakebolewski jakebolewski merged commit 8e32963 into master Apr 2, 2015
@jakebolewski jakebolewski deleted the jb/cmdlineargorder branch April 2, 2015 19:17
@mbauman
Copy link
Member

mbauman commented Apr 3, 2015

Loading .juliarc.jl this early means that we can no longer make modifications to the REPL. I simply had using TerminalExtensions in my juliarc (which no longer works), and I'm pretty sure this will also affect folks who were changing their keymaps or things like that.

@KristofferC
Copy link
Member

FWIW modifications can still be done with atreplinit but directly changing fields in the repl does not work (because it doesn't exist yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants