Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackOverflowError during precompilation of StructuralIdentifiability on Julia 1.12 #56040

Closed
sumiya11 opened this issue Oct 8, 2024 · 10 comments · Fixed by #56304
Closed

StackOverflowError during precompilation of StructuralIdentifiability on Julia 1.12 #56040

sumiya11 opened this issue Oct 8, 2024 · 10 comments · Fixed by #56304
Labels
types and dispatch Types, subtyping and method dispatch

Comments

@sumiya11
Copy link
Contributor

sumiya11 commented Oct 8, 2024

On Julia 1.12, version of October 7, 2024, the following command produces a StackOverflowError with
the latest StructuralIdentifiability v0.5.9:

./julia -e "using StructuralIdentifiability"

The full error is

Precompiling packages...
Info Given StructuralIdentifiability was explicitly requested, output will be shown live ^[[0K
^[[0K
^[[0K[522855] signal 11 (1): Erreur de segmentation
^[[0Kin expression starting at none:0
^[[0Kintersect at /home/ademin/downloads/julia/src/subtype.c:3957
^[[0Kintersect_union at /home/ademin/downloads/julia/src/subtype.c:2473
^[[0Kintersect at /home/ademin/downloads/julia/src/subtype.c:3971
^[[0Kintersect_union at /home/ademin/downloads/julia/src/subtype.c:2473
^[[0Kintersect at /home/ademin/downloads/julia/src/subtype.c:3964
^[[0Kintersect_all at /home/ademin/downloads/julia/src/subtype.c:4163
^[[0Kintersect_aside at /home/ademin/downloads/julia/src/subtype.c:2443
^[[0Kintersect at /home/ademin/downloads/julia/src/subtype.c:3951
^[[0Kintersect_all at /home/ademin/downloads/julia/src/subtype.c:4163
^[[0Kintersect_aside at /home/ademin/downloads/julia/src/subtype.c:2443
^[[0Kvar_lt at /home/ademin/downloads/julia/src/subtype.c:724

[the same lines repeated 15k times]

intersect at /home/ademin/downloads/julia/src/subtype.c:3989
intersect_unionall_ at /home/ademin/downloads/julia/src/subtype.c:3271
intersect_unionall at /home/ademin/downloads/julia/src/subtype.c:3358
intersect at /home/ademin/downloads/julia/src/subtype.c:3981
intersect_all at /home/ademin/downloads/julia/src/subtype.c:4163
jl_type_intersection_env_s at /home/ademin/downloads/julia/src/subtype.c:4409
jl_collect_edges at /home/ademin/downloads/julia/src/staticdata_utils.c:532
jl_prepare_serialization_data at /home/ademin/downloads/julia/src/staticdata.c:2751
ijl_create_system_image at /home/ademin/downloads/julia/src/staticdata.c:3217
ijl_write_compiler_output at /home/ademin/downloads/julia/src/precompile.c:155
ijl_atexit_hook at /home/ademin/downloads/julia/src/init.c:276
jl_repl_entrypoint at /home/ademin/downloads/julia/src/jlapi.c:1060
main at /home/ademin/downloads/julia/cli/loader_exe.c:58
unknown function (ip: 0x7fee1a829d8f)
__libc_start_main at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
_start at /home/ademin/downloads/julia/usr/bin/julia (unknown line)
Allocations: 176827254 (Pool: 176824534; Big: 2720); GC: 216
Warning: detected a stack overflow; program state may be corrupted, so further execution might be unreliable.
fatal: error thrown and no exception handler available.
StackOverflowError(

This issue a duplicate of SciML/StructuralIdentifiability.jl#362.

Any help with tackling this is appreciated. Thank you !

@giordano
Copy link
Contributor

giordano commented Oct 8, 2024

Any help with tackling this is appreciated.

If you have exact commits of the last known working version and the first non-working version, you can run git bisect and narrow down the culprit (as suggested by the label added above).

@sumiya11
Copy link
Contributor Author

sumiya11 commented Oct 8, 2024

bisect points to 4381c05

@sumiya11
Copy link
Contributor Author

sumiya11 commented Oct 8, 2024

cc @N5N3

@N5N3 N5N3 added types and dispatch Types, subtyping and method dispatch and removed types and dispatch Types, subtyping and method dispatch labels Oct 8, 2024
@N5N3
Copy link
Member

N5N3 commented Oct 8, 2024

@sumiya11 Thanks for the bisecting.
BTW, does v1.11.0 work for you?

@N5N3 N5N3 removed the bisect wanted label Oct 8, 2024
@sumiya11
Copy link
Contributor Author

sumiya11 commented Oct 8, 2024

v1.11.0 doesn't work
v1.10.5 works
Not sure about the v1.11.0-rc series.

@N5N3
Copy link
Member

N5N3 commented Oct 8, 2024

Thanks again. That commit haven't been backported to release-1.10 branch, so 1.10.5 works well.

@sumiya11
Copy link
Contributor Author

@N5N3 Thank you very much for fixing this so quickly.

Do you know if the fix gets in 1.11.2 ?

KristofferC pushed a commit that referenced this issue Oct 24, 2024
@KristofferC
Copy link
Member

Do you know if the fix gets in 1.11.2 ?

I backported this so yes.

@N5N3, to avoid merge conflicts I also backported #54745. Is that ok with you?

@N5N3
Copy link
Member

N5N3 commented Oct 24, 2024

@KristofferC Yes, that pr didn't bother daily pkg eval.

@pogudingleb
Copy link

Thanks, @N5N3 !

KristofferC pushed a commit that referenced this issue Oct 30, 2024
KristofferC pushed a commit that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types and dispatch Types, subtyping and method dispatch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants