Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is failing i686 due to broken test that seems to have been added recently #53025

Closed
vtjnash opened this issue Jan 23, 2024 · 2 comments · Fixed by #53029
Closed

CI is failing i686 due to broken test that seems to have been added recently #53025

vtjnash opened this issue Jan 23, 2024 · 2 comments · Fixed by #53029
Labels
ci Continuous integration regression Regression in behavior compared to a previous version

Comments

@vtjnash
Copy link
Member

vtjnash commented Jan 23, 2024 

      From worker 12:	┌ Info: REPL: trace compile output:
      From worker 12:	└ precompile(Tuple{typeof(Base.hashindex), String, Int32})
REPL                                             (12) |         failed at 2024-01-22T03:21:39.867
Test Failed at /cache/build/tester-amdci5-8/julialang/julia-master/julia-b0605606b6/share/julia/stdlib/v1.11/REPL/test/precompilation.jl:34
  Expression: n_precompiles <= expected_precompiles
   Evaluated: 1 <= 0

https://buildkite.com/julialang/julia-master/builds/32540#018d2f02-6d81-455c-b257-595c4e118a1b
@vtjnash vtjnash added regression Regression in behavior compared to a previous version ci Continuous integration labels Jan 23, 2024
@IanButterworth
Copy link
Member

Test was added in #52783
If a PR wasn't merged with this failing and the failure is intermittent, then I guess the test needs more wiggle room.

@vtjnash
Copy link
Member Author

vtjnash commented Jan 24, 2024

It failed on that PR before merging also (we don't give red for failures on this test currently, though we should)

@IanButterworth IanButterworth mentioned this issue Jan 24, 2024
Merged
vtjnash pushed a commit that referenced this issue Jan 24, 2024
@IanButterworth
Int64 -> Int in fixed precompile statements (#53029)
f5816f4 
Fixes #53025
@vtjnash vtjnash mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous integration regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Int64 -> Int in fixed precompile statements IanButterworth/julia
2 participants
@vtjnash @IanButterworth