-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests fail, no method isxdigit(Int32) #5142
Comments
This test appears to pass on Travis, and |
please send:
|
|
I rebuild everything after Does travis cover 32 bit machines? |
See also #4813 |
I can confirm that this is a 32-bit problem. It happens on 32-bit wine and 32-bit ubuntu builds. |
This is where I admit that I don't know what's going on:
(Note that this "no method" error is really just the underlying error reported above being caught by an overzealous
However, if we just plug in the definition of
If we wrap that definition in a function though, we get an error again (instead of the correct value which is indeed
|
My very vague suspicion is that this might be due to @loladiro's recently merged tuple optimization branch. |
I'll grab myself a 32bit system and see what's going on. |
This seems to be a reappearance of #4066:
(in code_llvm, the output of the tupleref gets boxed via jl_box_int32, then passed to jl_apply_generic) If I turn off inlining, it fails while emitting a reference to the 2nd element of |
64-bit test code: julia> bitstype 64 Int5142
julia> f(x::Int64) = "bad"
f (generic function with 1 methods)
julia> f(x::Int5142) = "good"
f (generic function with 2 methods)
julia> function g(a)
x=a?(int64(0),reinterpret(Int5142,int64(0))):(int64(1),reinterpret(Int5142,int64(1)))
f(x[2]::Int5142)
end
g (generic function with 1 method)
julia> g(true)
"bad"
julia> function h(a)
x=a?(int64(0),reinterpret(Int5142,int64(0))):(int64(1),reinterpret(Int5142,int64(1)))
x[2]::Int5142
end
h (generic function with 1 method)
julia> h(true)
ERROR: type: h: in typeassert, expected Int5142, got Int64
in h at none:3 |
This teaches jl_new_bits how to create heap-allocated tuples from flat, stack-allocated bits-type tuples. It also ensures that allocate_box_dynamic always marks the julia type of its return values.
While testing a bugfix, I ran into this unrelated error, which lets the test suite fail in test
string.jl
, line 62The text was updated successfully, but these errors were encountered: