Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESTDIR should not include /usr/ in it #391

Closed
anaisbetts opened this issue Feb 19, 2012 · 6 comments
Closed

DESTDIR should not include /usr/ in it #391

anaisbetts opened this issue Feb 19, 2012 · 6 comments
Assignees
Labels
building Build system, or building Julia or its dependencies

Comments

@anaisbetts
Copy link

Related to #6 (sorry for possibly beating this dead horse), but if you really want to use DESTDIR like Autotools' --prefix, you shouldn't have a /usr/ after it. The default DESTDIR should be /usr/, which makes it easy to install to /usr/local (or wherever).

So, for example, the line:

install -d $(DESTDIR)/usr/share/julia/lib

Should more properly be:

install -d $(DESTDIR)/share/julia/lib

This way, I can set DESTDIR to either /usr/local or /usr and it still works

@ghost ghost assigned vtjnash and ViralBShah Feb 19, 2012
@ViralBShah
Copy link
Member

Yes, I don't like this. The only reason I did this was to play nice with a debian package build's default stuff. I guess I should figure out how to get debian packages building without requiring /usr in DESTDIR.

@exaos
Copy link
Contributor

exaos commented Feb 26, 2012

Maybe you can use $(INSTALL) ... $(DESTDIR)/@prefix@/share/... instead of only $(INSTALL) ... $(DESTDIR)/usr/share/....

@ViralBShah
Copy link
Member

Can you create a pull request?

@exaos
Copy link
Contributor

exaos commented Feb 26, 2012

OK, please see #465

@JeffBezanson
Copy link
Member

Can this be closed now?

@ViralBShah
Copy link
Member

Yes. Good enough for me.

-viral

On 27-Feb-2012, at 9:12 AM, [email protected] wrote:

Can this be closed now?


Reply to this email directly or view it on GitHub:
#391 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

No branches or pull requests

5 participants