Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random errors in method definitions #3740

Closed
johnmyleswhite opened this issue Jul 17, 2013 · 2 comments
Closed

Random errors in method definitions #3740

johnmyleswhite opened this issue Jul 17, 2013 · 2 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@johnmyleswhite
Copy link
Member

From what I can see, Julia randomly fails to define some methods in DataFrames correctly. Below are two runs of the current DataFrames master branch test suite in sequence: the first fails and the second succeeds even though nothing has changed in the underlying code in between. This has been happening for a long time now, but the randomness has made it hard for me to pin down.

What seems to happen is that line 402 of dataarray.jl sometimes get defined correctly and other times winds up getting defined as if it returned nothing. Perhaps there's some race condition in the method definitions? I honestly have no idea how to make sense of this. I used to think it had something to do with the data sets we generated using an RNG, but that seems less likely now.

jmwmacbookpro:DataFrames johnmyleswhite$ julia run_tests.jl 
Running tests:
 * test/dataarray.jl
 * test/extras.jl
 * test/pooleddataarray.jl
 * test/data.jl
 * test/index.jl
 * test/dataframe.jl
 * test/operators.jl
 * test/io.jl
 * test/constructors.jl
 * test/abstractarray.jl
 * test/booleans.jl
 * test/indexing.jl
 * test/sort.jl
 * test/iteration.jl
 * test/colfuncs.jl
 * test/duplicates.jl
 * test/padding.jl
 * test/tabulation.jl
 * test/datamatrix.jl
ERROR: no method *(DataArray{Float64,1},Nothing)
 in include_from_node1 at loading.jl:91
 in anonymous at no file:35
 in include_from_node1 at loading.jl:91
 in process_options at client.jl:274
 in _start at client.jl:347
at /Users/johnmyleswhite/.julia/DataFrames/test/datamatrix.jl:45
at /Users/johnmyleswhite/.julia/DataFrames/run_tests.jl:36

jmwmacbookpro:DataFrames johnmyleswhite$ julia run_tests.jl 
Running tests:
 * test/dataarray.jl
 * test/extras.jl
 * test/pooleddataarray.jl
 * test/data.jl
 * test/index.jl
 * test/dataframe.jl
 * test/operators.jl
 * test/io.jl
 * test/constructors.jl
 * test/abstractarray.jl
 * test/booleans.jl
 * test/indexing.jl
 * test/sort.jl
 * test/iteration.jl
 * test/colfuncs.jl
 * test/duplicates.jl
 * test/padding.jl
 * test/tabulation.jl
 * test/datamatrix.jl

Sorry for raising such a strange issue.

@simonster
Copy link
Member

@johnmyleswhite I tried to track down the cause of this failure a while back and filed #3400.

@johnmyleswhite
Copy link
Member Author

Ah. Sorry for the double issue then.

Keno pushed a commit that referenced this issue Dec 21, 2023
Stdlib: Pkg
URL: https://github.com/JuliaLang/Pkg.jl.git
Stdlib branch: master
Julia branch: master
Old commit: 85f1e5564
New commit: 3c86ba27e
Julia version: 1.11.0-DEV
Pkg version: 1.11.0
Bump invoked by: @IanButterworth
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Pkg.jl@85f1e55...3c86ba2

```
$ git log --oneline 85f1e5564..3c86ba27e
3c86ba27e add `add --weak/extra Foo` to add to [weakdeps] or [extras] (#3708)
2e640f92f respect --color=no in Pkg.precompile (#3740)
cbd5d08ad Automatically add compat entries when adding deps to a package (#3732)
03de920b3 rm old manual handling of `--compiled-modules` (#3738)
314d5497b Use realpaths for temp dirs during tests. Fix SparseArrays `why` breakage (#3734)
a6531d4be environments.md: update Julia version (#3715)
a509bc062 Revise the API of is_manifest_current. (#3701)
60b7b7995 rm incorrect kwargs in add docstring (#3733)
```

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants