-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken test coverage of functions inside functions #36825
Comments
It's a bit of a bigger bug, but I'm going to close this for at least the cases that aren't explicitly evil:
|
vtjnash
added a commit
that referenced
this issue
Aug 27, 2020
vtjnash
added a commit
that referenced
this issue
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm having some trouble getting Julia to properly compute my test coverage.
A simple example of what goes wrong is in https://codecov.io/gh/Juice-jl/LogicCircuits.jl/src/257b9a792cb506329c7bb27e2ddfdedb1a097af7/src/LoadSave/vtree_line_compiler.jl
As you can see, there are functions defined inside of another function, and these are not accounted for properly. The code on line 45-48 is clearly not dead, and is actually executed in the unit tests, but not accounted for. Meanwhile the function headers on lines 44 and 50 are marked as not covered, even though they are executed during test.
Similar issues can be seen in other parts of my code that have a similar pattern: https://codecov.io/gh/Juice-jl/LogicCircuits.jl/src/257b9a792cb506329c7bb27e2ddfdedb1a097af7/src/LoadSave/circuit_line_compiler.jl
What's obviously a bug here is that some function bodies are covered, while their headers are not, which should be impossible.
The text was updated successfully, but these errors were encountered: