Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docstring for Expr #29244

Closed
stevengj opened this issue Sep 18, 2018 · 0 comments · Fixed by #30697
Closed

docstring for Expr #29244

stevengj opened this issue Sep 18, 2018 · 0 comments · Fixed by #30697
Assignees
@JeffBezanson
Labels
docs This change adds or pertains to documentation

Comments

@stevengj
Copy link
Member

stevengj commented Sep 18, 2018 •
edited
Loading

The Expr type currently has no docstring. Since this is a documented part of the metaprogramming API, it should have a docstring.

Its docstring might be a good place to list all of the valid surface-syntax AST nodes. As was commented on discourse, there is a manual section on the internal lowered AST, whereas the "public" metaprogramming manual section only has a few examples of Expr nodes.
@stevengj stevengj added the docs This change adds or pertains to documentation label Sep 18, 2018
@JeffBezanson JeffBezanson self-assigned this Jan 11, 2019
JeffBezanson added a commit that referenced this issue Jan 11, 2019
@JeffBezanson
some documentation improvements
afdb69d 
fix #29244, document `Expr`
fix #30648, link `isdefined` to `isassigned`
update docstring for `macro`
fix variable scope description in manual
@JeffBezanson JeffBezanson mentioned this issue Jan 11, 2019
Merged
JeffBezanson added a commit that referenced this issue Jan 12, 2019
@JeffBezanson
some documentation improvements (#30697)
0ecaffb 
fix #29244, document `Expr`
fix #30648, link `isdefined` to `isassigned`
update docstring for `macro`
fix variable scope description in manual
KristofferC pushed a commit that referenced this issue Feb 11, 2019
@JeffBezanson @KristofferC
some documentation improvements (#30697)
3207490 
fix #29244, document `Expr`
fix #30648, link `isdefined` to `isassigned`
update docstring for `macro`
fix variable scope description in manual

(cherry picked from commit 0ecaffb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

some documentation improvements JuliaLang/julia
2 participants
@JeffBezanson @stevengj