-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dense linear algebra cleanups #2062
Comments
Why drop the |
The ! version of the LAPACK.potrf! function will still be available for programmers who wish to overwrite an existing array. Having chold! in addition seemed like overkill. |
Unless I misunderstand, it seems like that removes the (useful) functionality of getting a Factorization object when you want to avoid copying the input matrix. What about things like |
Maybe have |
@ViralBShah Do you plan to create a branch for working on these changes? |
I have created |
@mlubin We will lose that capability for dense in routines such as Depending on how the dense stuff goes, we will also need to rethink the sparse stuff. The interfaces need an overhaul in any case in sparse due to the recent |
Shall we create a type DimMisMatchException <: Exception in base.jl? I want to throw such an exception in blas.jl and it probably wouldn't be a good idea to have the BLAS module import the LAPACK module. |
That seems like a good idea, so that we can give more structured errors in a bunch of other places as well. |
I think the operation of factorizing a matrix and destroying the input is a reasonably high-level concept that someone who doesn't know anything about LAPACK or |
I'm kind of with Miles on this one. Being able to avoid allocating temporary arrays without needing to learn the rather esoteric and complex LAPACK interface seems like a good thing to me. I'd rather read a sentence about how |
Let's do all the other work here and keep the bang versions of these functions as they exist, until we have a clearer idea. |
I'm going to move this from 0.1 to 0.2 also. |
The proposal is to
LAPACK.LapackDimMisMatch
where lapack is repeated twice.blas.jl
, avoid repetition of all functions twice. For eg., makegemm
callgemm!
.Factorization
and related methods to documentationsvd
perhaps we should have a Factorization type as well that makes it easy to solvechold
tocholfact
etc. for consistencyblas.jl
with default values for parameters such asalpha
andbeta
indgemm
.[ edit: Add a few more work items. Keep the ! versions also -- ViralBShah]
The text was updated successfully, but these errors were encountered: