Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hvcat of heterogeneous combinations of dense matrices and vectors is sparse #17686

Closed
Sacha0 opened this issue Jul 28, 2016 · 0 comments
Closed

hvcat of heterogeneous combinations of dense matrices and vectors is sparse #17686

Sacha0 opened this issue Jul 28, 2016 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@Sacha0
Copy link
Member

Sacha0 commented Jul 28, 2016 

julia> hvcat((2,), rand(4), rand(4, 4))
4×5 sparse matrix with 20 Float64 nonzero entries:
    [1, 1]  =  0.0589684
    [2, 1]  =  0.991264
    [3, 1]  =  0.268054
    [4, 1]  =  0.660864
    [1, 2]  =  0.769509
    [2, 2]  =  0.813596
    [3, 2]  =  0.603633
    [4, 2]  =  0.979977
    [1, 3]  =  0.921781
    [2, 3]  =  0.140218
    [3, 3]  =  0.86215
    [4, 3]  =  0.822429
    [1, 4]  =  0.969399
    [2, 4]  =  0.728482
    [3, 4]  =  0.978269
    [4, 4]  =  0.43144
    [1, 5]  =  0.998329
    [2, 5]  =  0.216226
    [3, 5]  =  0.358381
    [4, 5]  =  0.0556406

Missed case in #16722? Best!
@JeffBezanson JeffBezanson added the bug Indicates an unexpected problem or unintended behavior label Jul 28, 2016
JeffBezanson added a commit that referenced this issue Jul 28, 2016
@JeffBezanson
fix #17686, hvcat of dense matrices and vectors should be dense
28ec527
@Sacha0 Sacha0 mentioned this issue Jul 28, 2016
Merged
Sacha0 added a commit to Sacha0/julia that referenced this issue Jul 28, 2016
@Sacha0
Make hvcats of heterogeneous combinations of dense matrices and vec…
5cbaf12 
…tors yield dense arrays (fixes JuliaLang#17686).
JeffBezanson added a commit that referenced this issue Jul 29, 2016
@JeffBezanson
Merge pull request #17690 from Sacha0/sparsegencat
ba46baf 
Fix #17680 (sparse general concatenation) and #17686 (concatenation of heterogeneous Matrix-Vector combinations)
KristofferC pushed a commit that referenced this issue Jul 30, 2016
@Sacha0 @KristofferC
Make hvcats of heterogeneous combinations of dense matrices and vec…
00f3156 
…tors yield dense arrays (fixes #17686).
mfasi pushed a commit to mfasi/julia that referenced this issue Sep 5, 2016
@Sacha0 @mfasi
Make hvcats of heterogeneous combinations of dense matrices and vec…
0b374fb 
…tors yield dense arrays (fixes JuliaLang#17686).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeffBezanson @Sacha0