improve performance of setindex! on IdDict (#33009)

JuliaLang · Aug 23, 2019 · d1979e3 · d1979e3 · nanosoldier · Aug 24, 2019
1 parent 6821437
commit d1979e3
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/base/abstractdict.jl b/base/abstractdict.jl
@@ -579,7 +579,9 @@ end
 
 function setindex!(d::IdDict{K,V}, @nospecialize(val), @nospecialize(key)) where {K, V}
     !isa(key, K) && throw(ArgumentError("$(limitrepr(key)) is not a valid key for type $K"))
-    val = convert(V, val)
+    if !(val isa V) # avoid a dynamic call
+        val = convert(V, val)
+    end
     if d.ndel >= ((3*length(d.ht))>>2)
         rehash!(d, max(length(d.ht)>>1, 32))
         d.ndel = 0