Deprecate callable Regex objects

JuliaLang · Mar 2, 2018 · c067271 · c067271
1 parent c9c99f3
commit c067271
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1069,6 +1069,8 @@ Deprecated or removed
 
   * `contains` has been deprecated in favor of a more general `isfound` function ([#26283]).
 
+  * `Regex` objects are no longer callable. Use `isfound` instead ([#26283]).
+
   * The methods of `range` based on positional arguments have been deprecated in favor of
     keyword arguments ([#25896]).
 

diff --git a/base/deprecated.jl b/base/deprecated.jl
@@ -1457,6 +1457,7 @@ end
 # PR #26283
 @deprecate contains(haystack, needle) isfound(needle, haystack)
 @deprecate contains(s::AbstractString, r::Regex, offset::Integer) isfound(r, s, offset=offset)
+@deprecate (r::Regex)(s) isfound(r, s)
 
 # Issue #25786
 @deprecate_binding DevNull devnull

diff --git a/base/regex.jl b/base/regex.jl
@@ -153,8 +153,6 @@ function isfound(r::Regex, s::SubString; offset::Integer=0)
                      r.match_data)
 end
 
-(r::Regex)(s) = isfound(r, s)
-
 """
     match(r::Regex, s::AbstractString[, idx::Integer[, addopts]])