Improve efficiency of minimum(::Diagonal)

julia> DM = Diagonal(rand(100));

julia> @Btime minimum($DM);    # before
  27.987 μs (0 allocations: 0 bytes)

julia> @Btime minimum($DM);    # after
  246.091 ns (0 allocations: 0 bytes)

stdlib/LinearAlgebra/src/diagonal.jl

@@ -81,6 +81,12 @@ function size(D::Diagonal,d::Integer)
     return d<=2 ? length(D.diag) : 1
 end
 
+function Base.minimum(D::Diagonal{T}) where T <: Number
+    mindiag = minimum(D.diag)
+    size(D, 1) > 1 && return (min(zero(T), mindiag))
+    return mindiag
+end
+
 @inline function getindex(D::Diagonal, i::Int, j::Int)
     @boundscheck checkbounds(D, i, j)
     if i == j

stdlib/LinearAlgebra/test/diagonal.jl

@@ -80,6 +80,11 @@ Random.seed!(1)
         for func in (det, tr)
             @test func(D) ≈ func(DM) atol=n^2*eps(relty)*(1+(elty<:Complex))
         end
+
+        if eltype(D) <: Real
+            @test minimum(D) ≈ minimum(DM)
+        end
+
         if relty <: BlasFloat
             for func in (exp, sinh, cosh, tanh, sech, csch, coth)
                 @test func(D) ≈ func(DM) atol=n^3*eps(relty)