Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
hide kwcall methods from the backtrace (#47373)
They are not strictly internal, but also not strictly external, so just assume they should be hidden. Perhaps, in the future, we should figure out a way to signal directly in the line number value that this line can be hidden, so only exactly the inner call gets hidden, but not errors that happen in the kwsorter itself (for example, for computing default values). Then all of these could print comparable backtraces (rather than just hiding the kwcall, as this PR does): ``` julia> f(; a, b) = error() f (generic function with 1 method) julia> f() ERROR: UndefKeywordError: keyword argument `a` not assigned Stacktrace: [1] f() @ Main ./REPL[1]:1 [2] top-level scope @ REPL[2]:1 julia> f(b=1) ERROR: UndefKeywordError: keyword argument `a` not assigned Stacktrace: [1] kwcall(::NamedTuple{(:b,), Tuple{Int64}}, ::typeof(f)) @ Main ./REPL[1]:1 [2] top-level scope @ REPL[3]:1 julia> f(a=1) ERROR: UndefKeywordError: keyword argument `b` not assigned Stacktrace: [1] kwcall(::NamedTuple{(:a,), Tuple{Int64}}, ::typeof(f)) @ Main ./REPL[1]:1 [2] top-level scope @ REPL[4]:1 julia> f(a=1, b=2) ERROR: Stacktrace: [1] error() @ Base ./error.jl:44 [2] f(; a::Int64, b::Int64) @ Main ./REPL[1]:1 [3] kwcall(::NamedTuple{(:a, :b), Tuple{Int64, Int64}}, ::typeof(f)) @ Main ./REPL[1]:1 [4] top-level scope @ REPL[5]:1 ``` Fix #47319
- Loading branch information
abce8af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Executing the daily package evaluation, I will reply here when finished:
@nanosoldier
runtests(ALL, isdaily = true, configuration=(rr=true,))
abce8af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your package evaluation job has completed - possible new issues were detected. A full report can be found here.