Skip to content

Commit

Permalink
codegen: print failure reason when verifier fails (#45642)
Browse files Browse the repository at this point in the history
  • Loading branch information
vtjnash authored Jun 11, 2022
1 parent 329fd49 commit a9e3cc7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/llvm-alloc-opt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1177,7 +1177,7 @@ bool AllocOpt::runOnFunction(Function &F, function_ref<DominatorTree&()> GetDT)
optimizer.initialize();
optimizer.optimizeAll();
bool modified = optimizer.finalize();
assert(!verifyFunction(F));
assert(!verifyFunction(F, &errs()));
return modified;
}

Expand Down
2 changes: 1 addition & 1 deletion src/llvm-demote-float16.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ static bool demoteFloat16(Function &F)
if (erase.size() > 0) {
for (auto V : erase)
V->eraseFromParent();
assert(!verifyFunction(F));
assert(!verifyFunction(F, &errs()));
return true;
}
else
Expand Down
2 changes: 1 addition & 1 deletion src/llvm-gc-invariant-verifier.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ void GCInvariantVerifier::visitLoadInst(LoadInst &LI) {
if (Ty->isPointerTy()) {
unsigned AS = cast<PointerType>(Ty)->getAddressSpace();
Check(AS != AddressSpace::CalleeRooted,
"Illegal store of callee rooted value", &LI);
"Illegal load of callee rooted value", &LI);
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/llvm-julia-licm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ struct JuliaLICM : public JuliaPassContext {
if (changed && SE) {
SE->forgetLoopDispositions(L);
}
assert(!verifyFunction(*L->getHeader()->getParent()));
assert(!verifyFunction(*L->getHeader()->getParent(), &errs()));
return changed;
}
};
Expand Down

2 comments on commit a9e3cc7

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

Please sign in to comment.