Fast implementation of digits(::Integer, base = 2)

JuliaLang · Apr 14, 2019 · a357d95 · a357d95
1 parent 1c88c0e
commit a357d95
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/base/intfuncs.jl b/base/intfuncs.jl
@@ -755,9 +755,15 @@ function digits!(a::AbstractVector{T}, n::Integer; base::Integer = 10) where T<:
     isempty(a) && return a
 
     if base > 0
-        for i in eachindex(a)
-            n, d = divrem(n, base)
-            a[i] = d
+        if base == 2
+            for i in eachindex(a)
+                a[i] = (n >> (i - 1)) & 1
+            end
+        else
+            for i in eachindex(a)
+                n, d = divrem(n, base)
+                a[i] = d
+            end
         end
     else
         # manually peel one loop iteration for type stability