-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add sparse matvec to perf benchmark (#4707)
- Loading branch information
1 parent
3db073d
commit 8ce7dfb
Showing
2 changed files
with
57 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# https://github.com/JuliaLang/julia/issues/4707 | ||
|
||
#----------------- Get the A matrix | ||
function getDivGrad(n1,n2,n3) | ||
|
||
# the Divergence | ||
D1 = kron(speye(n3),kron(speye(n2),ddx(n1))) | ||
D2 = kron(speye(n3),kron(ddx(n2),speye(n1))) | ||
D3 = kron(ddx(n3),kron(speye(n2),speye(n1))) | ||
# DIV from faces to cell-centers | ||
Div = [D1 D2 D3] | ||
|
||
return Div*Div'; | ||
end | ||
|
||
#----------------- 1D finite difference on staggered grid | ||
function ddx(n) | ||
# generate 1D derivatives | ||
return d = spdiags(ones(n)*[-1 1],[0,1],n,n+1) | ||
end | ||
|
||
#------------- Build a diagonal matrix | ||
function spdiags(B,d,m,n) | ||
# spdiags(B,d,m,n) | ||
# creates a sparse matrix from its diagonals | ||
|
||
d = d[:] | ||
p = length(d) | ||
|
||
len = zeros(p+1,1) | ||
for k = 1:p | ||
len[k+1] = int(len[k]+length(max(1,1-d[k]):min(m,n-d[k]))) | ||
end | ||
a = zeros(int(len[p+1]),3) | ||
for k = 1:p | ||
# Append new d[k]-th diagonal to compact form | ||
i = max(1,1-d[k]):min(m,n-d[k]) | ||
a[(int(len[k])+1):int(len[k+1]),:] = [i i+d[k] B[i+(m>=n)*d[k],k]] | ||
end | ||
|
||
A = sparse(int(a[:,1]),int(a[:,2]),a[:,3],m,n); | ||
|
||
return A | ||
|
||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ce7dfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@staticfloat Do we need to do anything to get speed center to track this newly added benchmark?
8ce7dfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, you can see it already popped up!
8ce7dfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
8ce7dfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is strange that there is a performance difference between different blas libraries, given that this operation does not use any BLAS operations.
8ce7dfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that was just a system load issue.
8ce7dfb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of that benchmark is pretty misleading since it doesn't in any way indicate that it's a sparse matvec rather than a dense one.