Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
try to fix the intermittent failures since #10380
I believe the bug was due to the need to hash typename->primary specially, based on how other type functions treat it.
- Loading branch information
7ec501d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this breaks an assumption made by the deserializer that jl_object_id won't access the
jl_datatype_t->name
field, since rebuilding an ObjectIdDict may see a partially constructed type. for some reason, this seems to come up particularly often on my PR branch:https://travis-ci.org/JuliaLang/julia/builds/62794883
https://ci.appveyor.com/project/StefanKarpinski/julia/build/1.0.4753
https://travis-ci.org/JuliaLang/julia/builds/62794891
what's your preference on how to fix this? there seem to be 9 usages of ObjectIdDict in base (2 in serializer, an empty one in multi.jl, another empty one in inference.jl, an empty one in stream.jl, an empty one in socket.jl, a small one in replutil.jl, and presumably the rest are caused by docs.jl)