Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip out tree_hash for stdlibs that have have been freed in newer julia versions #4062

Merged
merged 2 commits into from
Oct 29, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Operations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,12 @@ end
####################

function load_tree_hash!(registries::Vector{Registry.RegistryInstance}, pkg::PackageSpec, julia_version)
if is_stdlib(pkg.uuid, julia_version) && pkg.tree_hash !== nothing
# manifests from newer julia versions might have stdlibs that are upgradable (FORMER_STDLIBS)
# that have tree_hash recorded, which we need to clear for this version where they are not upgradable
IanButterworth marked this conversation as resolved.
Show resolved Hide resolved
pkg.tree_hash = nothing
return pkg
end
tracking_registered_version(pkg, julia_version) || return pkg
hash = nothing
for reg in registries
Expand Down
Loading