Precompilation workload: restore the original depot and load paths #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
KristofferC
reviewed
Oct 17, 2023
fatteneder
reviewed
Oct 17, 2023
vchuravy
reviewed
Oct 17, 2023
Co-authored-by: Valentin Churavy <[email protected]>
|
@fatteneder @DilumAluthge this makes me almost think that we should have the tests https://github.com/JuliaLang/julia/blob/4d2d8490bdee8f457948b949441e95a69a775217/test/testdefs.jl#L25-L29 as part of the precompilation harness and yell at the user if their precompile scripts don't restore them. |
|
Since this is the last thing that the process does I don't see how this does anything. But maybe it is nice aesthetically. |
Afterwards we do the work of serializing the actual data and JuliaLang/julia#49866 is going to look at the depot path to rewrite the source paths we store in the cache file |
DilumAluthge
commented
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.